Skip to content

Add runsc update command #9876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add runsc update command #9876

wants to merge 1 commit into from

Conversation

kevinmingtarja
Copy link

This PR adds the runsc update command, which enables updating resource constraints of running containers. It is the runsc equivalent of runc update.

Closes #9554.

@google-cla Google CLA
Copy link

google-cla bot commented Jan 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

ayushr2
ayushr2 reviewed Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@ayushr2 ayushr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

A friendly reminder that this PR had no activity for 120 days.

@github-actions github-actions bot added the stale-pr This PR has not been updated in 120 days. label May 9, 2024
@ayushr2
Copy link
Collaborator

ayushr2 commented May 9, 2024

@kevinmingtarja Do you have a chance to revive this?

@kevinmingtarja
Copy link
Author

@kevinmingtarja Do you have a chance to revive this?

ah yes sorry, i just finished my finals and i can start working on this again!

@github-actions github-actions bot removed the stale-pr This PR has not been updated in 120 days. label May 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

A friendly reminder that this PR had no activity for 120 days.

@github-actions github-actions bot added the stale-pr This PR has not been updated in 120 days. label Sep 7, 2024
@kevinmingtarja
Copy link
Author

remove stale

@github-actions github-actions bot removed the stale-pr This PR has not been updated in 120 days. label Sep 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

A friendly reminder that this PR had no activity for 120 days.

@github-actions github-actions bot added the stale-pr This PR has not been updated in 120 days. label Jan 6, 2025
@kevinmingtarja
Copy link
Author

remove stale

@kevinmingtarja kevinmingtarja marked this pull request as ready for review April 8, 2025 08:04
@kevinmingtarja
Copy link
Author

Hi @ayushr2, sorry for the super long delay! This PR is ready for review now.

To recap:

  • the main additions are container.Set() and Cgroup.Set() (for all its types, cgroupv1, cgroupv2, cgroupSystemd)
  • added unit tests at cgroup_v2_test.go and systemd_test.go
  • modified existing cgroupv1 and cgroupv2 E2E tests at cgroup_test.go
  • tested manually as well on a VM with cgroupv2 and systemd, both via Docker and runsc directly

@kevinmingtarja kevinmingtarja requested a review from ayushr2 April 8, 2025 08:04
@kevinmingtarja kevinmingtarja changed the title WIP: Add runsc update command Add runsc update command Apr 10, 2025
ayushr2
ayushr2 reviewed Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@ayushr2 ayushr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

Please squash your commits into 1, otherwise all the intermediate commits will also be merged into master once this is accepted.

@manninglucas manninglucas self-requested a review April 16, 2025 23:29
manninglucas
manninglucas reviewed Apr 17, 2025
View reviewed changes
ayushr2
ayushr2 reviewed Apr 22, 2025
View reviewed changes
Copy link
Collaborator

@ayushr2 ayushr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mostly looks good!

@kevinmingtarja kevinmingtarja requested a review from ayushr2 April 22, 2025 21:30
ayushr2
ayushr2 approved these changes Apr 22, 2025
View reviewed changes
@kevinmingtarja
runsc: add update command
941b6f0 
This change enables updating resource constraints of running containers. It is the runsc equivalent of runc update.
@ayushr2 ayushr2 added ready to pull and removed stale-pr This PR has not been updated in 120 days. labels Apr 22, 2025
copybara-service bot pushed a commit that referenced this pull request Apr 22, 2025
@kevinmingtarja @gvisor-bot
Add runsc update command
c1ce7a1 
This PR adds the `runsc update` command, which enables updating resource constraints of running containers. It is the runsc equivalent of `runc update`.

Closes #9554.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#9876 from kevinmingtarja:update-command-impl 941b6f0
PiperOrigin-RevId: 750357910
@copybara-service copybara-service bot mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manninglucas manninglucas manninglucas approved these changes

@ayushr2 ayushr2 ayushr2 approved these changes

Assignees
No one assigned
Labels
ready to pull
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker update command fails with runsc
3 participants
@kevinmingtarja @ayushr2 @manninglucas