-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add runsc update command #9876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add runsc update command #9876
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far!
A friendly reminder that this PR had no activity for 120 days. |
@kevinmingtarja Do you have a chance to revive this? |
ah yes sorry, i just finished my finals and i can start working on this again! |
A friendly reminder that this PR had no activity for 120 days. |
remove stale |
A friendly reminder that this PR had no activity for 120 days. |
remove stale |
59e6781
to
5e29a0b
Compare
Hi @ayushr2, sorry for the super long delay! This PR is ready for review now. To recap:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work!
Please squash your commits into 1, otherwise all the intermediate commits will also be merged into master once this is accepted.
24427cb
to
2fe4965
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks mostly looks good!
2fe4965
to
29edc75
Compare
29edc75
to
ace473c
Compare
This change enables updating resource constraints of running containers. It is the runsc equivalent of runc update.
ace473c
to
941b6f0
Compare
This PR adds the
runsc update
command, which enables updating resource constraints of running containers. It is the runsc equivalent ofrunc update
.Closes #9554.